[ http://jira.andromda.org/browse/SPRING-104?page=comments#action_12000 ]
Peter Friese commented on SPRING-104:
-------------------------------------
Thanks for the patch, Ryan.
However, it is better to sumbit patches in unified format, which can be parsed
by Eclipse (which most of the Spring cartridge committers use). It looks like
this:
Index: SpringServiceLogicImpl.java
===================================================================
RCS file:
/cvsroot/andromda/cartridges/andromda-spring/src/java/org/andromda/cartridges/spring/metafacades/SpringServiceLogicImpl.java,v
retrieving revision 1.23
diff -u -r1.23 SpringServiceLogicImpl.java
--- SpringServiceLogicImpl.java 15 Aug 2005 19:55:48 -0000 1.23
+++ SpringServiceLogicImpl.java 22 Aug 2005 08:55:23 -0000
@@ -325,7 +325,7 @@
// port
if (hasServiceRemotePort())
{
- result += ":${remotePort";
+ result += ":${remotePort}";
}
// service name
> SpringServiceLogicImpl.java missing '}' on variable in clientContext.xml
> ------------------------------------------------------------------------
>
> Key: SPRING-104
> URL: http://jira.andromda.org/browse/SPRING-104
> Project: Spring Cartridge
> Type: Bug
> Versions: 3.1M1, 3.1RC1
> Environment: Java 1.5, Mac OSX 10.4.2
> Reporter: Ryan Marsh
> Assignee: Peter Friese
> Attachments: SpringServiceLogicImpl.java.diff
>
> clientContext.xml is generated with a missing '}' after a variable name. cvs
> diff (against current) to fix this is below.
> Index:
> cartridges/andromda-spring/src/java/org/andromda/cartridges/spring/metafacades/SpringServiceLogicImpl.java
> ===================================================================
> RCS file:
> /cvsroot/andromda/cartridges/andromda-spring/src/java/org/andromda/cartridges/spring/metafacades/SpringServiceLogicImpl.java,v
> retrieving revision 1.23
> diff -r1.23 SpringServiceLogicImpl.java
> 328c328
> < result += ":${remotePort";
> ---
> > result += ":${remotePort}";
> 528c528
> < }
> \ No newline at end of file
> ---
> > }
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
