[ http://jira.andromda.org/browse/UMLMETA-53?page=history ]
     
Wouter Zoons closed UMLMETA-53:
-------------------------------

     Resolution: Fixed
    Fix Version: 3.1 Final

> isReturnTypePresent should return false in case of null
> -------------------------------------------------------
>
>          Key: UMLMETA-53
>          URL: http://jira.andromda.org/browse/UMLMETA-53
>      Project: UML Metafacades
>         Type: Bug
>     Versions: 3.1RC1
>     Reporter: Hans Schippers
>     Assignee: Wouter Zoons
>      Fix For: 3.1 Final

>
> The current implementation of Operation.isReturnTypePresent() is as follows:
>     protected boolean handleIsReturnTypePresent()
>     {
>         boolean hasReturnType = true;
>         if (this.getReturnType() != null)
>         {
>             hasReturnType = 
> !StringUtils.trimToEmpty(this.getReturnType().getFullyQualifiedName()).equals("void");
>         }
>         return hasReturnType;
>     }
> In other words, it returns "true" except when the return type is "void". That 
> means it returns "true" even in cases where no return type is specified. This 
> may not have been a bug until now, since there is a constraint demanding the 
> presence of a return type. However, since constraints can be turned off now, 
> I think it would be better to return false if no return type is present.




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

Reply via email to