[ http://jira.andromda.org/browse/JSF-13?page=comments#action_12894 ] 

Leif Johansson commented on JSF-13:
-----------------------------------

Even more interesting: sorting doesn't work in konqueror - i.e clicking the 
sort link causes an npe. I suspect 
that this is caused by the same problem: command links use broken javascript 
somehow. Still investigating this.

> use commandButton for buttons
> -----------------------------
>
>          Key: JSF-13
>          URL: http://jira.andromda.org/browse/JSF-13
>      Project: JSF cartridge
>         Type: Improvement

>     Reporter: Leif Johansson
>     Assignee: Chad Brandon
>     Priority: Minor

>
> The following diff makes jsf render buttons using af:commandButton instead of 
> af:commandLink
> Index: src/templates/jsf/views/facelets/view-table.xhtml.vsl
> ===================================================================
> RCS file: 
> /cvsroot/andromda/cartridges/andromda-jsf/src/templates/jsf/views/facelets/Attic/view-table.xhtml.vsl,v
> retrieving revision 1.1.2.15
> diff -u -r1.1.2.15 view-table.xhtml.vsl
> --- src/templates/jsf/views/facelets/view-table.xhtml.vsl       31 May 2006 
> 19:08:38 -0000      1.1.2.15
> +++ src/templates/jsf/views/facelets/view-table.xhtml.vsl       9 Jun 2006 
> 08:57:15 -0000
> @@ -89,9 +89,9 @@
>                  <h:panelGroup styleClass="actionColumn"><t:graphicImage 
> url="/images/space.gif"/></h:panelGroup>
>              </f:facet>
>              <h:panelGroup styleClass="actionColumn">
> -                <af:commandLink 
> text="#{messages['$action.trigger.messageKey']}" 
> action="#{${action.controller.beanName}.${action.triggerName}}">
> +                <af:commandButton 
> text="#{messages['$action.trigger.messageKey']}" 
> action="#{${action.controller.beanName}.${action.triggerName}}">
>  #renderTableCommandLinkParameters()
> -                </af:commandLink>
> +                </af:commandButton>
>              </h:panelGroup>
>          </af:column>
>  #end
> @@ -99,4 +99,4 @@
>      </af:table>
>  </h:form>
>  </ui:composition>
> -</html>
> \ No newline at end of file
> +</html>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.andromda.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Reply via email to