Useless code about table names calculation
------------------------------------------

         Key: EJB-112
         URL: http://jira.andromda.org/browse/EJB-112
     Project: EJB Cartridge
        Type: Bug

 Environment: AndroMDA 3.4-SNAPSHOT + EJB3 cartridge
    Reporter: Olivier THIERRY
 Assigned to: Vance Karimi 
    Priority: Trivial


It looks like there is useless code in EJB3EntityFacadeLogicImpl class about 
table names. This class overrides getTableName() method so that 
@andromda.persistence.table tagged value has priority over entity name to 
calculate the table name for an entity. But this is already the case in 
metafacade Entity classes, so we don't need to override this method. I guess 
this used to be not supported by AndroMDA core so it was done in EJB3 
cartridge, but we don't need this anymore.

We have a similar problem in EJB3AssociationFacadeLogicImpl. This time we still 
need to override getTableName. But we could call getSqlNameFromTaggedValue 
method of EntityMetafacadeUtils and we don't need to have the same method 
(exactly the same source code !) in EJB3EntityMetafacadeUtils.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.andromda.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Reply via email to