Hello @Matthew. As i remember this patch fixes only `ng-options` behavior on digest. It looked like simple implementation bug in misuse of internal structures. Anyway yes it is edzius. :) I haven't submited this patch elswhere also no side effects noticed. Soon after i post the patch here angular v1.2.0 released and it seemed to fix this issue for me so the patch was left aside. However if you still see the same issue with 1.2 we might have been be hearing different parts of same echo. Yes, please, push it upstream if it really solves your problem ;)
Cheers Edvinas 2014 m. kovas 14 d., penktadienis 00:35:02 UTC+2, [email protected] rašė: > > Hey @Edvinas, it looks like this patch solves an issue we had with a timer > (calling digest) in v1.08. > > However, this issue still seems to be in v1.2.0 without patching. > > I had a dig around, and nerd-stalked you on github (edzius right?), and it > doesn't look like you submitted this patch to core, nor does it look like > it's on the radar in the issue tracker. > > Have you submitted this patch any place other than this mailing list? > Are there side effects of this patch that may make you hesitate to submit > it as a pull request? > Would you mind if I took this and tried pushing this upstream on your > behalf? > > Cheers > ~Matthew. > > > On Wednesday, 22 May 2013 03:08:25 UTC+12, Edvinas Stunžėnas wrote: >> >> I did some digging in angular sources, seems that problem occurs due to >> wrong >> checking of existing options selected state. Here is my patch for angular >> v1.0.6 >> that worked for me. Hope it works for you too >> >> {{{ >> Index: angular/angular.js >> =================================================================== >> --- angular.orig/angular.js 2013-05-21 17:14:23.454552989 +0300 >> +++ angular/angular.js 2013-05-21 17:16:38.610550189 +0300 >> @@ -14642,7 +14642,7 @@ >> if (existingOption.id !== option.id) { >> lastElement.val(existingOption.id = option.id); >> } >> - if (existingOption.element.selected !== option.selected) >> { >> + if (existingOption.selected !== option.selected) { >> lastElement.prop('selected', (existingOption.selected >> = option.selected)); >> } >> } else { >> }}} >> >> On Tuesday, March 19, 2013 7:57:37 PM UTC+2, Jose M wrote: >> >>> I'm seeing this weird issue with Firefox when hovering over a select >>> option in a select input with options built by ng-options. >>> >>> Whenever you hover over any option that is not the currently selected >>> option, the browser will reset the currently highlighted option after a >>> $scope.$apply occurs. In our application we currently do a poll for some >>> data and we are often calling $scope.$apply every second or less when we >>> get new data. >>> >>> Below is a jsfiddle which demonstrates the behavior. I have set it up >>> to do a fake poll call with a $scope.$apply every 250 milliseconds using >>> the $timeout service. >>> >>> http://jsfiddle.net/Xn7PA/12/ >>> >>> Click on the dropdown and hover the mouse over any of the options that >>> is not the default empty one. >>> >>> I'm using Firefox version 19.0.2 (on Mac OSX) and in our application we >>> are using angularjs version 1.1.3 (although in the jsfiddle it's setup with >>> AngularJS version 1.1.1 and the issue still manifests itself). >>> >>> It works fine in Chrome (stable and Canary), Safari, and Opera. >>> >>> In IE9 I also see the issue after I select any option (the first one is >>> not selected by default). >>> >> -- You received this message because you are subscribed to the Google Groups "AngularJS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/angular. For more options, visit https://groups.google.com/d/optout.
