Hi there, I need some discussion about the topic:
According to $routeProvider documentation 
<https://docs.angularjs.org/api/ngRoute/provider/$routeProvider>, 
reloadOnSearch option from when method's route parameter works as: "reload 
route when only $location.search() or $location.hash() changes, if it's set 
to true".
But I think these two options should be separated, as reloadOnSearch for 
$location.search() changes and reloadOnHash for $location.hash() changes, 
so that situations like "*I wanna change hash without page reload, but when 
I change search then it should be reloaded*" can be implemented easily.

In detail,
[reloadOnSearch=true] - reload route when only $location.search() or 
$location.hash() changes
should be changed to
[reloadOnSearch=true] - reload route when only $location.search() changes
[reloadOnHash=true] - reload route when only $location.hash() changes

This idea came from simple thought: When search is changed, in most case 
the page refreshes, but when hash changes, it just scrolls browser to some 
waypoint without reloading.
The situation I talked above "*I wanna change hash without page reload, but 
when I change search then it should be reloaded*" can be implemented by 
$watch-ing $location.search(), then trigger $route.reload() when the search 
is changed.
Implementation is not a problem. I'm just asking that whether this 
suggestion is valid or not.
I can carry on without such option but just thought that this should be it.

-- 
You received this message because you are subscribed to the Google Groups 
"AngularJS" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.

Reply via email to