One of the things that I'm not super-keen on with these strategies (of "dummy" or lightweight versions in core, with the main implementation outside of core) is that it tightly couples core with the extra module, and it frequently trips people up when they accidentally use incompatible versions of each module (numerous bugs like this have been filed about ngAnimate already).
That said, if the API is really well thought out so that we don't make a habit of changing it and breaking it too much, I like this idea. On Saturday, 31 January 2015 14:10:17 UTC-5, Shahar Talmi wrote: > > *Summary* > Move all cookies read/write logic to ngCookies, making it necessary to > include ngCookies in order to use any features that require cookies. > > *Motivation* > Currently, cookies read/write logic is located in $browser. The reason for > this is that cookie reading is required by $http for xsrf-token support. > But there is no good reason cookie writing to be in core except for > consistency. In #10530 we moved the cookie writing logic to ngCookies, but > this still feels a bit weird. We would like to move all cookie read/write > logic to ngCookies, meaning that xsrf-token feature in $http will work only > if ngCookies is included. > > *Compatibility Risk* > This will break all applications that use xsrf-token unless they include > ngCookies. This is pretty easily solved by simply adding ngCookies. > > > *Plans for Implementation* > The $cookies service will be added to angular core as a null object > implementation that acts like there are no cookies. This way $http will use > it and if you include ngCookies it will be replaced by the real > implementation and the xsrf-token feature will work again > > *Prior Art* > This is very similar to what is being done in ngAnimate > -- You received this message because you are subscribed to the Google Groups "AngularJS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/angular. For more options, visit https://groups.google.com/d/optout.
