I've written a pipe which I would like to submit for a PR to angular2 repo. I've followed the instructions for formatting and testing. However, if I add the pipe to the common pipes ( seems logical to me that it should be in the common pipes, but I may be wrong) , the test fails because the public API has changed (changing the public api tests is off limits unless given permission) .
Can I still submit my PR despite the public API test failing or should I just not add my code to the common pipes? The pipe is ReplacePipe (it basically calls a String.prototype.replace() with some type checking on the input and arguments) and since I've had plenty of use for a similar filter I wrote in my angular1 projects, I thought it'd be great to have it built in in angular2. Even if such a pipe would not be approved, my question still stands for future reference, should I choose to try and add other features. -- You received this message because you are subscribed to the Google Groups "AngularJS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/angular. For more options, visit https://groups.google.com/d/optout.
