I have approval from my company and will create the pull request today.
> On 21 Oct. 2016, at 10:50, Matt Davis <[email protected]> wrote: > > Yeah, I had that one on my list as a planned core module build for 2.3, so if > you've got a decent start on one, let's see it! > > -Matt > >> On Wednesday, October 19, 2016 at 1:52:20 AM UTC-7, jhawkesworth wrote: >> Hi, >> >> Definitely create a pull request, its the best way to get your code reviewed >> by others (and the only way to get it included with ansible). Definitely >> worth working your way through this if you haven't read it yet - >> http://docs.ansible.com/ansible/developing_modules.html >> >> Also, please create one pull request per module. >> >> Many thanks. >> >> Jon >> >> >> >>> On Tuesday, October 18, 2016 at 9:38:03 PM UTC+1, [email protected] >>> wrote: >>> Hi, >>> >>> I have developed a Windows version of the wait_for module that mimics part >>> of functionality of the Linux wait_for module. >>> >>> Currently my module is capable of the following: >>> >>> wait for the existence of a file (path parameter) when state=present >>> wait for a file (set by path parameter) to not exist when state=absent >>> wait for a file (set by path parameter) to contain a string matching a >>> regular expression (set by search_regex parameter) >>> >>> I would like to share this with the community to enable others to add more >>> functionality and to reuse what i have done so far. >>> >>> Should I create a pull request to contribute this? >>> >>> Also, if i have multiple modules to share, should this be done in one pull >>> request or multiple? Sorry for the dumb question but i am new to this :) >>> >>> Thanks >>> Paul > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Ansible Development" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/ansible-devel/lLBvDmjsGEc/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Ansible Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
