If you start out with forking the Ansible repo in github (there's a button for that) into your own github account you can do the following: git clone https://github.com/<myuseraccount>/ansible cd ansible git checkout -b "win_url_improvements" <make your changes> git add . git commit -m "Made nice changes" git push origin win_url_improvements
If you go to "your" copy of the ansible repo on github now, it will have a button for submitting a pull request. You should request pulling your own win_url_improvements branch into ansible/ansible:devel On Thursday, February 9, 2017 at 12:57:43 PM UTC+1, Edit Karasz wrote: > > Hi, > > Thank you for your reply. > I have some question about the pull request. I understand that I have to > merge into the devel branch but which branch may I use to add my changes? > Am I suppose to create one? What are the naming conventions? Where should > I subscribe to be able to cut a branch? > Should both the Linux and the Windows module updates go to the same > branch/pull request? > Thank You, > Kind Regards, > Edit > > On Sunday, 5 February 2017 10:14:36 UTC, jhawkesworth wrote: >> >> Hi >> >> This sounds useful, so the next step would be preparing a pull request so >> that others can review your changes. >> >> One thing worth considering is trying to make options similar to the >> get_url module, just so it is easy to switch to the windows version if >> needed. >> >> Don't worry about who maintains it. Some modules are considered to be >> essential for ansible to function and so get more scrutiny from the ansible >> core team. >> >> Some general advice about pull requests. Its worth spending a little time >> getting familiar with git and github if you aren't already. Don't be >> surprised if you get asked to make changes. Also, well worth reading the >> guidelines on creating documentation and testing that your changes to the >> documents parse ok by running ansible-doc on your changed module. One >> thing that helps get pull requests merged is having tests. Writing >> integration tests for ansible is straightforward as the integration tests >> are just playbooks. From a source checkout, have a look in >> test/integration/targets - they are useful to know about anyway as often >> contain examples of how to do things. >> >> Hope this helps, >> >> Jon >> >> -- You received this message because you are subscribed to the Google Groups "Ansible Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
