Hi Naval, I am working on 1 PR request which has stale_ci tag and got "All checks have passed" through shippable Devops, what does that mean?
I have done all sanity and compile test locally. What should I do now to merge it to Ansible Directory? PR #44256 Please help..Thanks in advance Roshan On Tuesday, 4 December 2018 18:45:43 UTC+5:30, Naval wrote: > > Hi Roshan, > > Sanity and Compile are must. Depending on modules units and integration > are optional, not sure about Cloud module. > > Thanks > Naval > > On Monday, December 3, 2018 at 10:58:16 AM UTC+5:30, roshan wanaskar wrote: >> >> What are the test required if I want to add Module in Cloud Module >> Directory. and what is the process to review module? Which of these tests >> are required among Units, Integration, Sanity and Compile/ >> >> On Wednesday, 17 June 2015 02:38:51 UTC+5:30, Greg DeKoenigsberg wrote: >>> >>> We currently have 99 new modules in Ansible Extras that need review. >>> You can see the list here: >>> >>> https://github.com/ansible/ansible-modules-extras/labels/new_module >>> >>> If you are a module author yourself (official list: >>> https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md), >>> >>> please take the time to review one of these modules. The process is >>> simple: >>> >>> 1. Go to the pull request URL and leave a note that you’re in the >>> process of reviewing the module. >>> 2. Run the module to test its basic functionality. >>> 3. Review the module for its adherence to the module guidelines. >>> (http://docs.ansible.com/developing_modules.html#module-checklist). >>> 4. Add any necessary feedback to the pull request. >>> 5. Once the module looks good, give it a +1! >>> >>> Any module with two +1s from official module reviewers will be >>> approved for inclusion in Ansible Extras. >>> >>> Thanks for your help in improving the PR merge process. If you have >>> any feedback, comments or questions, please don't hesitate to ask. >>> >>> --g >>> >>> -- >>> Greg DeKoenigsberg >>> Ansible Community Guy >>> >>> Find out why SD Times named Ansible >>> their #1 Company to Watch in 2015: >>> http://sdtimes.com/companies-watch-2015/ >>> >> -- You received this message because you are subscribed to the Google Groups "Ansible Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to ansible-devel+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
