My only point of contention is on lining up variable assignments. 

Sooner or later someone comes along with a longer name. 

At that point, you either realign existing assignments (ruining 
attribution) or have a misaligned assignment. 

See https://github.com/ansible/ansible/pull/5389/files for a particularly 
degenerate example.

In general though, this is a great combination of pragmatic and idiomatic 
guidelines. 

Will

On Monday, January 27, 2014 8:06:41 AM UTC+10, Michael DeHaan wrote:
>
> As we're getting larger I was finding myself sharing some tips repeatedly 
> (and leaving some others unexpressed), so I decided to start up a document.
>
> https://github.com/ansible/ansible/blob/devel/CODING_GUIDELINES.md
>
> Could probably use a little bit of reorg and standardization, but this is 
> a draft.
>
>
> -- 
> Michael DeHaan <[email protected] <javascript:>>
> CTO, AnsibleWorks, Inc.
> http://www.ansibleworks.com/
>
>  

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to