Absolutely brilliant!

Thanks for pulling that in so fast. 

> On 24 Jul 2014, at 00:11, Michael DeHaan <[email protected]> wrote:
> 
> Yep, Benno works for us and is awesome.
> 
> The unarchive fix is now merged, the command module bit is a bit different.
> 
> 
> 
> 
>> On Wed, Jul 23, 2014 at 6:59 PM, Mark Phillips <[email protected]> wrote:
>> It hits the unarchive module too, it would appear. Got bit by that in the 
>> middle of a demo/presentation last night (that'll teach me to be running 
>> from devel!)
>> 
>> There is a ticket Michael, looks like somebody has already fixed it too, and 
>> sent you the PR. 
>> 
>> https://github.com/ansible/ansible/pull/8263
>> 
>> Cheers
>> 
>> 
>>> On Wednesday, 23 July 2014 23:13:58 UTC+1, Michael DeHaan wrote:
>>> So currently the duplicate param detection does look inside some quoted 
>>> args that it should not.  We're working on a fix for this.
>>> 
>>> Should only happen when there are Foo= Foo= repeated in a shell/command 
>>> module, with the equal signs.
>>> 
>>> 
>>> 
>>> 
>>> 
>>>> On Wed, Jul 23, 2014 at 5:05 PM, Aaron Bull Schaefer <[email protected]> 
>>>> wrote:
>>>> A new issue has cropped up for me with v1.6.8 when running a command 
>>>> through the shell module that has an equal sign in the command:
>>>> 
>>>> - name: register the zone a nat instance
>>>>   shell: 'aws --region {{ aws_region }} ec2 describe-instances --filters 
>>>> "Name=tag:Name, Values=NAT Instance A" "Name=instance-state-code, 
>>>> Values=16" --query "Reservations[*].Instances[*].InstanceId" | jq 
>>>> --raw-output ".[][]"'
>>>>   changed_when: false
>>>>   register: zone_a_nat_instance
>>>> 
>>>> ...and the error I'm getting is:
>>>> 
>>>> TASK: [aws | register the zone a nat instance] 
>>>> ********************************
>>>> fatal: [localhost] => a duplicate parameter was found in the argument 
>>>> string (Name)
>>>> 
>>>> FATAL: all hosts have already failed -- aborting
>>>> 
>>>> Although there are technically two instances of 'Name=' in my command, 
>>>> it's not an actual Ansible module parameter, but part of the shell command 
>>>> I'd like to run. This task worked previously and no matter how I quote the 
>>>> above task (no surrounding quotes, single quotes, double quotes, -shell: > 
>>>> with a newline then the command, etc.), it throws the same error.
>>>> 
>>>> I did find this GitHub issue regarding the same error, but it seems like 
>>>> there are a number of issues going on in that thread: 
>>>> https://github.com/ansible/ansible/issues/8233#issuecomment-49924707
>>>> 
>>>> Any quick fixes? Is this an unintended consequence of the security fix?
>>>> 
>>>> -- 
>>>> Aaron Bull Schaefer
>>>> -- 
>>>> You received this message because you are subscribed to the Google Groups 
>>>> "Ansible Project" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>>> email to [email protected].
>>>> To post to this group, send email to [email protected].
>>>> 
>>>> To view this discussion on the web visit 
>>>> https://groups.google.com/d/msgid/ansible-project/d66b21ea-0570-4a37-a0d6-af8a3824e344%40googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ansible Project" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected].
>> To post to this group, send email to [email protected].
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/ansible-project/b46edbc0-aaa6-45d2-8987-30ec76d63eb7%40googlegroups.com.
>> 
>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to a topic in the Google 
> Groups "Ansible Project" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/ansible-project/pmXrj9jcYBY/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgx_W8qXbzSwer2oex9YkspS6EEt9v9Tn5Pg3OsdtYM6JA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/73AB59A3-BB00-43CC-9399-232490ED123C%40probably.co.uk.
For more options, visit https://groups.google.com/d/optout.

Reply via email to