Discussion on pull requests is a better subject for ansible-devel usually. All being said, I followed up with a question 3 days ago and it got flagged P3, and there are 160 of those in queue right now.
I had first requested some whitespace commits not go in, and this was fixed by a revert - which doesn't solve the history problem. It appears there are now about 12 other commits in there, so the best thing to do would be to resubmit this as a squashed patch containing just the one commit. Commits that take spaces in and add them back completely miss the point we had originally - which was about not breaking attribution on those lines in source control history, when there was no need to change those lines. On Thu, Jul 31, 2014 at 4:39 PM, Berend de Boer <[email protected]> wrote: > Hi ansible, > > Any more comments on my FreeBSD sysctl fixes? > https://github.com/ansible/ansible/pull/8256 > > You're probably very busy, so don't want to push anyone around here, but > in case it had inadvertently dropped off the radar, just a gentle reminder. > Would be very nice to have this in the next release, if that works for you > guys. > > All the best, > > Berend. > > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/5a121c29-661c-4045-b601-3989dfc23237%40googlegroups.com > <https://groups.google.com/d/msgid/ansible-project/5a121c29-661c-4045-b601-3989dfc23237%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgzMvjz5xmp5dKDQ3ybww7YmxzV8OYoKZpaoEXo%3DbVDQAQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
