Yeah I think the above syntax, and also in dependencies, would be fine. Dependency downloads are all in the ansible-galaxy CLI, so I think that would cover everything. We would just need the core change that would get the role name out correctly too.
Thanks! On Thu, Aug 14, 2014 at 6:43 AM, Will Thames <w...@thames.id.au> wrote: > I’ve solved the trimming the .git off the end and also the ability to > specify role_version in meta/main.yml > > It doesn’t work with an upgrade of a dependency because the check is > currently for if the role exists, not if it’s a particular version. > > I’ve added an integration test for all of this too - so I know > ansible-galaxy and ansible-playbook work with the changes against SCM roles > but not if the changes break existing roles inside or outside of galaxy - > be good to get some additional testing around this. > > Will > > > On 14 Aug 2014, at 18:13, Will Thames <w...@thames.id.au> wrote: > > Also, what is the intended mechanism for pinning versions in dependencies > in meta/main.yml? > > dependencies: > - git+http://git.example.com/repos/role-abc,v1.0 > > There’s probably some work to trim the .git off the role_name too (I just > don’t bother putting the .git in the repo url but maybe not all git servers > cope with that) > > On 14 Aug 2014, at 10:37, Will Thames <w...@thames.id.au> wrote: > > I'm happy enough with this approach but how do we apply that to role > dependencies. > > In my git test role I provide a git dependency: > > https://bitbucket.org/willthames/git-ansible-galaxy/src/1e58ef87f234926caaf5e6b1f2c5378d90f476b1/meta/main.yml?at=master > > This works with the ansible-galaxy in the pull request but would not as it > stands without some form of scm detection. > > On reflection, I think I'd be happiest with the scm+url suggestion - this > would eliminate the need for scm detection and keep the role_name/url, > role_version format of the rolesfile > role_name would continue to be derived from the repo name. > > From Sam's example, this would then look more like this (not 100% happy > with git+git but it's nicer than handling the special case). > > # Custom roles using various protocols > git+ssh://g...@git.acme.com:ansible/role-disa-stig-rhel6.git,1.0 > git+https://git.acme.com/ansible/role-kibana.git > git+git://g...@git.acme.com:ansible/role-logstash.git > > This would end up with roles called e.g. role-logstash, which might not be > what you want, but I would prefer to keep the rolesfile simple. > > Will > > On Thursday, August 14, 2014 12:59:43 AM UTC+10, Michael DeHaan wrote: >> >> +1 >> >> >> >> On Wed, Aug 13, 2014 at 10:57 AM, Sam Doran <sam....@me.com> wrote: >> >>> I like your syntax suggestion. That seems to fit more with the ansible >>> project. I agree that specifying the protocol would be a good idea. >>> >>> Here's what it might look like: >>> >>> # Galaxy roles >>> adham.helal.authentication >>> agios.nginx-unicorn,1.3 >>> >>> # Custom roles using various protocols >>> disa-stig-rhel6,git,ssh://g...@git.acme.com:ansible/role- >>> disa-stig-rhel6.git,1.0kibana,git,https://git.acme. >>> com:ansible/role-kibana.gitlogstash,git,git://g...@git.acme.com: >>> ansible/role-logstash.git >>> >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Ansible Project" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to ansible-proje...@googlegroups.com. >>> To post to this group, send email to ansible...@googlegroups.com. >>> To view this discussion on the web visit https://groups.google.com/d/ >>> msgid/ansible-project/2946b30e-e772-44af-9592- >>> f0fec3f8da30%40googlegroups.com >>> <https://groups.google.com/d/msgid/ansible-project/2946b30e-e772-44af-9592-f0fec3f8da30%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "Ansible Project" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/ansible-project/TawjChwaV08/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > ansible-project+unsubscr...@googlegroups.com. > To post to this group, send email to ansible-project@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/e3e48247-98bb-44db-912c-ca953b624c04%40googlegroups.com > <https://groups.google.com/d/msgid/ansible-project/e3e48247-98bb-44db-912c-ca953b624c04%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to ansible-project+unsubscr...@googlegroups.com. > To post to this group, send email to ansible-project@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/551E689E-2833-4AE3-999A-FFFB0F005E21%40thames.id.au > <https://groups.google.com/d/msgid/ansible-project/551E689E-2833-4AE3-999A-FFFB0F005E21%40thames.id.au?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to ansible-project+unsubscr...@googlegroups.com. To post to this group, send email to ansible-project@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgyxw8drgW6RAg2-JwVv24NUMqbuhFSKCBaoD7y-Yh__FQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
