Yep, style is a team thing. Part of this discussion was because Jeff is writing a book, I would prefer if we didn't advocate that simple key=value on one line was a bad practice in a book when it conflicts with the core docs, or that alternatively we should encourage structured args versus splitting on a line, since there's going to a point where that's needed.
The line-oriented argument is compelling if you want to see things in context, though I think in many cases people will be able to tell from the diff easily enough anyway. Ansible itself was intended to be easily diffable because of not using explicit dependencies and being order based and things like that. Ultimately it's "what works for your team", absolutely. On Mon, Aug 25, 2014 at 4:13 PM, Josh Smift <[email protected]> wrote: > MD> But Ansible playbooks are not Python, nor do we assume folks will need > MD> to know Python. > > Sure; I think that was just an example of a coding style that recommends > short lines (along with the Linux kernel coding style). > > FWIW, I think the diff argument is pretty compelling: I find it a lot > easier to read a diff of some parameter changes when there's one parameter > per line rather than one long line full of parameters. Maybe my archaic > line-oriented usage of diff is as archaic as my eighty-column terminal > windows, and all the cool kids these days are using color-highlighted > diffs that make it trivial to spot the one word that's changed between two > long lines of text, but I'm not, and suspect many aren't. > > All that said, this is just a style question, right? In which case I think > it's more important that the Ansible-using folks on your team agree on a > style, than that all Ansible users everywhere agree on one. > > -Josh ([email protected]) > > > > This email is intended for the person(s) to whom it is addressed and may > contain information that is PRIVILEGED or CONFIDENTIAL. Any unauthorized > use, distribution, copying, or disclosure by any person other than the > addressee(s) is strictly prohibited. If you have received this email in > error, please notify the sender immediately by return email and delete the > message and any attachments from your system. > > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/21499.39151.226836.102627%40gargle.gargle.HOWL > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgx%2B9VdeP6GpKXRCvbnUGdwiunVV0ROHzGLzXqh8juisHA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
