You guys should really start unit testing this stuff! I think it would save a lot of pain.
On 18 September 2014 01:08, Toshio Kuratomi <[email protected]> wrote: > > > On Wed, Sep 17, 2014 at 1:40 PM, Tobias Gesellchen <[email protected]> > wrote: > > Hi, >> >> the recent changes regarding the repository strings with private registry >> urls seem to be missing a detail. Looking at the changes for >> https://github.com/ansible/ansible/issues/8983 only the trailing tag >> seems to be recognized, but no "username" infix. >> Please have a look at >> https://github.com/docker/docker/blob/master/pkg/parsers/parsers.go#L72 >> where the "official" logic for parsing a canonical repository url is >> implemented. >> >> Did anyone have a chance to try a repository url like below? >> >> localhost.localdomain:5000/samalba/hipache:latest >> >> That gets parsed into: > > ('localhost.localdomain:5000/samalba/hipache', 'latest') > > Is that not what it's supposed to be? > > (Note: there's been several commits fixing bugs and then fixing bugs > introduced by fixes in recent days so if you're just looking at issues, > make sure that you also have had a chance to look at the latest version of > the code in the devel tree). > > -Toshio > > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/CAG9juEp2JmWTXiH_y0ZmR0wOXSAcPe1ETEoUnrv5KGsbMLbJhA%40mail.gmail.com > <https://groups.google.com/d/msgid/ansible-project/CAG9juEp2JmWTXiH_y0ZmR0wOXSAcPe1ETEoUnrv5KGsbMLbJhA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CADVA9h9HjhQ0LzupdAsZdJwgQrnNQWd%3DoY6i7VpcOHtF8tKZHA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
