Ok, a few things done just now: (A) merged Will's patch to docs (thanks!)
(B) merged Will's patch to add --version details for the submodules, which will be huge. I also tweaked it to understand what to do if there were no submodules. (C) I've tweaked the runtime code if a module is not found to look for the 'ping' module. If the 'ping' module can't be found, we know that submodule updates never happened. This should prevent development branch users who use GitHub, but don't know about this list, from getting confused about module paths not working -- which should make things rather self documenting. On Sun, Sep 28, 2014 at 11:18 AM, Michael DeHaan <mich...@ansible.com> wrote: > Awesome, digging in on these now. > > > > On Sat, Sep 27, 2014 at 9:10 PM, Will Thames <w...@thames.id.au> wrote: > >> Raised https://github.com/ansible/ansible/pull/9185 for the trivial doc >> fix (thanks Brian for the tip) >> >> I've managed to update all my module based PRs - it's definitely not easy >> to reproduce a set of commits from one repo to another (to be honest >> it's probably just easier to copy the fix and commit log if it's only a >> single commit which most PRs will typically be) - I only had two PRs which >> were module affecting though. >> >> The instructions in my gist do include rebasing against a currently quite >> recent version of devel (i.e. the last before the modules were removed from >> core) and if they look like something worth adding to a ticket stub I can >> create such a stub >> >> Also raised https://github.com/ansible/ansible/pull/9186 to improve >> ansible version information. It now looks like: >> >> ansible 1.8 (submodule_ansible_version c621f54538) last updated >> 2014/09/28 11:05:48 (GMT +1000) >> lib/ansible/modules/core: (ec2_snapshot_remove 3a77c31ecb) last updated >> 2014/09/27 18:23:31 (GMT +1000) >> lib/ansible/modules/extras: (detached HEAD 110250d344) last updated >> 2014/09/27 14:33:42 (GMT +1000) >> >> Will >> >> >> >> On 27 Sep 2014, at 22:40, Michael DeHaan <mich...@ansible.com> wrote: >> >> > Yeah I think we can keep it simple. >> > >> > If I've missed an "--init" somewhere the easiest thing is to link to a >> minimal pull request. >> > >> > Another thing I thought of >> > >> > (A) is making the "--version" command output the SHA's of the >> submodules when running from source. >> > (B) making runner arbitrarily look for the "ping" module, and if can't >> find one, if running from git, have the CLI suggest the git commands to run. >> > >> > We are likely going to be needing to close out module-tagged pull >> requests and suggest that they be resubmitted, but have not done so yet. >> > Having the instructions of how to do that in the message (like our >> usual ticket_stubs/ responses) I think would be super helpful. That being >> said, a lot has changed since, and many pull requests may be out of date - >> having some changes reapplied may be desirable. >> > >> > There are import scripts for moving bug tickets that I think we can >> use, though it's *slighty* problematic in that we have two repos and the >> system can't tell which is which. As such, we may ask these be trivially >> resubmitted. >> > >> > I'd say hold off on this now until we take some action on that ticket >> queue, which is the plan for next week. >> > >> > On Sat, Sep 27, 2014 at 7:36 AM, Brian Coca <brianc...@gmail.com> >> wrote: >> > simple commands for existing checkouts: >> > >> > git pull --rebase >> > git submodule update --init --recursive >> > >> > That should be enough >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups "Ansible Project" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to ansible-project+unsubscr...@googlegroups.com. >> > To post to this group, send email to ansible-project@googlegroups.com. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/ansible-project/CADn%2BHswXZRA3fFjXOV8XRuAzqa4PAbTV8RWt682TZTDSYnVrNQ%40mail.gmail.com >> . >> > For more options, visit https://groups.google.com/d/optout. >> > >> > >> > -- >> > You received this message because you are subscribed to a topic in the >> Google Groups "Ansible Project" group. >> > To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/ansible-project/TUL_Bfmhr-E/unsubscribe >> . >> > To unsubscribe from this group and all its topics, send an email to >> ansible-project+unsubscr...@googlegroups.com. >> > To post to this group, send email to ansible-project@googlegroups.com. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgzw9-0bHDZJ6kmztMJxYwhJf4qhiqBCmT2YkGSH%2BxjoDA%40mail.gmail.com >> . >> > For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ansible Project" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to ansible-project+unsubscr...@googlegroups.com. >> To post to this group, send email to ansible-project@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/ansible-project/B4C765EE-9C78-451C-8224-69FEAB60FCE8%40thames.id.au >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to ansible-project+unsubscr...@googlegroups.com. To post to this group, send email to ansible-project@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgyDZqmQVWLF3_m4X3i0uWOYN%2B4f2-_6Fj%3D2qOy6-rjAcA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
