Here's the code change to restart the container if env vars have changed:

https://github.com/forty9ten/ansible-modules-core/compare/ansible:devel...devel

Let me know what you think.

I know in the previous post I also talked about also checking other 
parameters such as volume and port.
Maybe that can be done as a separate PR.  I believe just the environmental 
detection is useful on its own.

Aaron

On Wednesday, September 24, 2014 12:17:11 PM UTC-4, Michael DeHaan wrote:
>
> There are no plans per se but that doesn't mean it's not a good idea.
>
> I think it would depend on whether this was easily queryable by docker-py, 
> but I imagine it would be.
>
> If you'd like to work on this, you are welcome, otherwise please file a 
> feature request in GitHub so we don't lose track of the idea.
>
> Thanks!
>
>
>
>
> On Wed, Sep 24, 2014 at 12:11 PM, Aaron Feng <[email protected] 
> <javascript:>> wrote:
>
>> Currently the docker module only restarts the container if the name 
>> parameter is specified and the image has changed.  Are there plans to also 
>> check if other docker parameters have changed such as env, port and volume?
>> It is pretty common to pass in configuration information via environment 
>> variables to containers.  It would be nice if the Ansible docker modules 
>> realizes docker parameters have changed, then automatically restart the 
>> container.
>> I don't think volume or port will change often but configuration 
>> information via environment variables will certainly evolve over time.
>>
>> Aaron
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ansible Project" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected] <javascript:>.
>> To post to this group, send email to [email protected] 
>> <javascript:>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/ansible-project/d9292738-d214-4a7e-98ef-c5e40e37d57b%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/ansible-project/d9292738-d214-4a7e-98ef-c5e40e37d57b%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/034ad05c-de40-43d1-b219-51304539dc3c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to