Let's not add a new backup parameter. The existing backup=yes/no parameter that only creates local backups needs to be overhauled to do remotes, and we can generalize it at this time.
On Fri, Dec 12, 2014 at 12:51 PM, Mzp45 <[email protected]> wrote: > > Sure, I'll work on the pull request. > > On Wednesday, December 10, 2014 1:17:42 PM UTC-5, tkuratomi wrote: >> >> Yeah, I just noticed that backup actually does exist on a lot of the >> file-like modules. I just hadn't noticed them before. So yeah, >> adding a backup parameter that does the same thing for sysctl seems >> like a good idea. Could you open a pull request if you can code it or >> an issue if you can't so that hte idea doesn't get lost? >> >> Thanks, >> -Toshio >> >> On Wed, Dec 10, 2014 at 8:20 AM, Mzp45 <[email protected]> wrote: >> > I was thinking an implementation along the lines of the "lineinfile" >> module >> > where you can edit a file and create a backup at the same time. For the >> > sysctl module if you have to edit a sysctl.conf file then a backup >> seems >> > like a good failsafe. >> > >> > On Tuesday, December 9, 2014 7:08:46 PM UTC-5, tkuratomi wrote: >> >> >> >> In general, ansible modules do not perform backups of files that they >> >> modify. I'm not sure that sysctl is especially special in this >> >> regard. Is there a reason you need this for sysctl but not for copy, >> >> or any of the other modules? >> >> >> >> -Toshio >> >> >> >> On Tue, Dec 9, 2014 at 7:41 AM, Mzp45 <[email protected]> wrote: >> >> > Hello, >> >> > Is there a way to create a backup of /etc/sysctl.conf when making a >> >> > change >> >> > using the sysctl core module? If not can this feature be added? >> >> > >> >> > Thanks >> >> > >> >> > -- >> >> > You received this message because you are subscribed to the Google >> >> > Groups >> >> > "Ansible Project" group. >> >> > To unsubscribe from this group and stop receiving emails from it, >> send >> >> > an >> >> > email to [email protected]. >> >> > To post to this group, send email to [email protected]. >> >> > To view this discussion on the web visit >> >> > >> >> > https://groups.google.com/d/msgid/ansible-project/ >> dacf22c0-e242-4cf8-9618-6e9678485f61%40googlegroups.com. >> >> > For more options, visit https://groups.google.com/d/optout. >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "Ansible Project" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an >> > email to [email protected]. >> > To post to this group, send email to [email protected]. >> > To view this discussion on the web visit >> > https://groups.google.com/d/msgid/ansible-project/ >> d08acda3-d1d5-465e-bb0f-60d301dfca5a%40googlegroups.com. >> > For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/ansible-project/a7f6dbd3-e391-40a7-b457-1b922e0d39b4%40googlegroups.com > <https://groups.google.com/d/msgid/ansible-project/a7f6dbd3-e391-40a7-b457-1b922e0d39b4%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgz-d8xvEX5S--035o5UU%3Dp8oMQeUJ9awa0eZp-DPG%2BRvw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
