Hello everyone,
I've noticed that the subversion module always reports changes when
updating, even though my repo (with svn:externals) has not changed.
It was linked to the way the module detects local modifications. The call
to "svn status" has no formatting options, and a regexp tries to
detect lines that correspond to a real local modifications (actually, all
it does is discard '?' lines, non-versioned files). But there are others
"svn status" codes that should be discarded ( 'X' and 'I' see {1} ).
More over, when a repo has externals, "svn status" output will no be easily
parsed, because some text lines appear :
"Performing status on external item at ....".
The solution I propose is to use the --quiet option for svn status, it
makes the output parsing-friendly, and only output anything if there are
local changes, which is exactly what is wanted here.
As a consequence, there is no more need for a regexp, only test if the
output is empty.
Here's a pull request that fixes this {2}.
Thanks in advance.
{1} http://svnbook.red-bean.com/en/1.7/svn.ref.svn.c.status.html
{2} https://github.com/ansible/ansible-modules-core/pull/783
--
You received this message because you are subscribed to the Google Groups
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/ansible-project/0c6a1f9a-0e8f-43f1-844e-b8814877e8aa%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
