Hello,
in PR #14805 <https://github.com/ansible/ansible/pull/14805> I provided a 
one line patch to allow writing modules with both:

from ansible.module_utils.<lib name> import *

and

from ansible.module_utils.<lib name> import AnsibleModule

As you can see in the build 
<https://travis-ci.org/ansible/ansible/builds/113691610> this extremely 
simple patch doesn't break anything.

The reasoning behind the patch is to be able to write PEP8 compliant code 
(wildcard imports are discouraged).

I understand that ansible does very 'interesting' things with that line as 
it is replaced by code coming from other sources to ship a single flat 
file. The problem is that the line we are talking about, despite as doing 
something very ansible specific, looks like an import (humans, IDEs and 
linters alike think that's just another regular import) so linters/IDEs 
trying to comply to PEP8 complains about the line.

That simple patch, addresses the issue described here and allows you to 
write PEP8 compliant code without breaking any functionality.

Thanks.
David

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/081731dc-a292-40f4-bd08-f969613e8065%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to