Re: linkoffline problems with javadoc

[Patrick Chanezon]

Hi Scott,
thanks for the tip, that's one bug I had not spotted.
I'm not a committer but I am actually working on a patch of the javadoc task in
which I will allow to have multiple link and linkoffline options (to solve bug
http://jakarta.apache.org/bugs/show_bug.cgi?id=64 ).

To do so, I will change the syntax and make them separate entities.
Then I think the best way to solve the bug you submitted is to have two
different attributes for linkoffline: docURL and packagelistURL.

As of the patch submission process, it is described in
http://jakarta.apache.org/guidelines/source.html

Have fun.

P@

Scott Came wrote:

> Hello ant-dev...
>
> I noticed that the javadoc task wraps quotes around arguments, as it should.
> However, this messes up linkoffline, which actually requires two arguments
> separated by a space.  Apparently the way javadoc is implemented, it expects
> docURL and packagelistURL to be separate elements in the command-line
> argument array, which doesn't jive with how the Javadoc task passes them in.
>
> Example:
>
> is:  javadoc ... -linkoffline "http://blah/myjavadocs
> src/packagelist-location"
> should be: javadoc ... -linkoffline "http://blah/myjavadocs";
> "src/packagelist-location"
>
> The solution with minimum impact on the rest of the task is to find the
> space in the linkoffline variable and replace it with quote-space-quote ("
> ").  There might be a better general solution, but this seemed good to me as
> I think linkoffline is the only option to which this applies.
>
> I have patched this code locally and it works on top of version 1.7 of the
> javadoc task.  Would the maintainers be interested in the patch?  If so, is
> the patch submission format documented somewhere?  (I looked around--esp on
> the "getting involved" page--and couldn't find it.)
>
> Regards,
> --Scott
>
> Scott Came
> Senior Consultant and Java Developer
> Puget Sound Systems Group, Inc
> Olympia, Washington
> (360) 491-PSSG

--
Patrick Chanezon, Vortex - Portal/EServices Technical Lead
Netscape Communications Corp. - http://people.netscape.com/chanezon/
Opinions are my own.

"Ouais, n'emp�che qu'� la retraite de Russie, c'est les mecs qu'�taient � la
tra�ne qu'ont �t� repass�s..." - Michel Audiard - Les Tontons Flingueurs


begin:vcard 
n:Chanezon;Patrick
tel;fax:603.388-9565
tel;work:650.937.6605
x-mozilla-html:TRUE
org:<CENTER><A HREF="http://www.iplanet.com/";><IMG SRC="http://www.iplanet.com/images/header_images/logo.gif"; BORDER=0 </A></CENTER>;Vortex
version:2.1
email;internet:[EMAIL PROTECTED]
title:<I>Vortex - Portal/EServices Technical Lead</I>
note:<A HREF="http://people.netscape.com/chanezon/";><IMG SRC="http://people.netscape.com/chanezon/patrick_photo_identite.jpg"; BORDER=0 HEIGHT=70 WIDTH=49></A><BR>Have Fun with <A HREF="http://www.javasoft.com/";><IMG SRC="http://www.javasoft.com/images/logos/javalogo52x88.gif"; border="0" HEIGHT="88" WIDTH="52"></A><BR><hr><BR>
adr;quoted-printable:;;Netscape Communications Corp.=0D=0A501 E. Middlefield Road=0D=0ABuilding 6=0D=0AMV-025;Mountain View;CA;94043;USA
fn:Patrick Chanezon
end:vcard