Conor is right, p1 must exist for the createProperty method to work. Nothing gets refected into p1 until execute anyway (including the nested properties), when the ProjectHelp gets called. �Thats the only point we care about property resolution, so as long as its done just before the call to ProjectHelper, we are ok. All user properties are included in the regular properties, so the loop to handle project.getProperties reflects the current state of all properties in the project. �The next loop to set the nested properties ensures that is any properties have already been set in the parent project will _not_ be overridden in the subproject. �This follows the current set of rules for properties. (oops, gotta run. �day long meeting... sigh...) Glenn McAllister TID - Software Developer - VisualAge for Java IBM Toronto Lab, (416) 448-3805 "An approximate answer to the right question is better than the right answer to the wrong question." - John W. Tukey Please respond to [EMAIL PROTECTED] To: � � � [EMAIL PROTECTED] cc: Subject: � � � �RE: [PATCH] Less memory consumption for subbuilds [IMAGE] > From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > > I've just looked through this patch, Glenn has moved the part where > the subproject's properties get set from init to execute. > > Can anybody see a reason why we shouldn't move the whole code from > init over to execute? > Stefan, The only issue would be the createProperty method. Obviously p1 must be instantiated. I don't know if there will be any effect of setting the user properties first. (I have to go and look at that code a little to know the difference). I'd also keep it as a separate method to be called from execute(). Conor (Embedded image moved to file: pic02668.pcx)
pic02668.pcx
Description: Binary data
