I think it makes sense to allow people to use the ; in the text attribute as
it makes it a bit easier to cut and paste from other files. I can't see a
really need to having multiple statement blocks other than for neatness
(using the src attribute is obviously the tidiest), unless we make them
conditional on the success of previous statements. That's going to get a bit
complex I would have thought.
-----Original Message-----
From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
Sent: 25 July 2000 09:00
To: [EMAIL PROTECTED]
Subject: Re: The new SQLExec task
>>>>> "CM" == Conor MacNeill <[EMAIL PROTECTED]>
writes:
>> (1) Remove the sql attribute and add a addText(String)
method,
>> making the task accept #PCDATA. So
CM> I actually added that bit so you could so things
without needing
CM> an external file. No objections to you changing that.
The
CM> semicolon processing is not presently part of the sql
attribute
CM> handling so you would need to add that,
I thought about moving the processing to a
runStatements(Reader)
method that would be called with a FileReader or
StringReader
depending on circumstances.
CM> or have a nested element approach such as <sql>
<statement>
CM> <statement> </sql>
CM> This removes the delimiter processing which might be
attractive.
I have a strong RDBMS background and putting a ; at the end
of my SQL
statements is more than natural for me - and you would need
the
processing for files anyway.
What do others think of this?
Stefan
