Gero, I have committed your patch. Would it be possible to send me a unified diff for the index.html rather than the whole file. I haven't committed the changes in that file.
Cheers Conor > -----Original Message----- > From: Gero Vermaas, Sun Java Center [mailto:[EMAIL PROTECTED] > Sent: Saturday, 23 September 2000 21:44 > To: [EMAIL PROTECTED] > Subject: Re: [PATCH] Filter task enhanced, reads filters from file. > > > You're right. Attached you find a correct version with "filtersfile" > > Regards, > Gero > ----- Original Message ----- > From: "Diane Holt" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Saturday, September 23, 2000 11:31 > Subject: Re: [PATCH] Filter task enhanced, reads filters from file. > > > > --- "Gero Vermaas, Sun Java Center" <[EMAIL PROTECTED]> wrote: > > > I've added a "filtersfile" parameter to the Filter task. > > > > Hi Gero, > > > > Here you say it's "filtersfile", but in index.html and in the code, it's > > "filterfile". I think it probably really should be "filtersfile", since > > that would match "includesfile" and "excludesfile", and keep things like > > this consistent (so people don't have to remember things like, > "Oh right, > > it's without the "s" in the <filter> task"). > > > > Thanks, > > Diane > > > > > > ===== > > ([EMAIL PROTECTED]) > > > > > > > > __________________________________________________ > > Do You Yahoo!? > > Send instant messages & get email alerts with Yahoo! Messenger. > > http://im.yahoo.com/ > > >
