> Regarding the output we faced a small problem: > Main calls Project.fireBuildStarted() when starting > the build and Project.fireBuildFinished() at the > end. > We would like to do the same to trigger the > BuildListeners, > but unfortunately both methods are protected. > Could You make these methods public? > (From a seperation of concerns point of view it > would > be even better if Project itself would signal > the start and end of a build but I didn't find a > good location for such a change, because Main does > a lot of initialization work after calling > fireBuildStarted()).
vote +10000 :^] I'm also in big favor of this. In order to launch builds in Antidote I've had to "copy" some code from Main.java to support the expected "executeTask" behavior. I think that there is room for some refactoring and better abstraction of the code in Main.java and Project.java. Both 'fireBuildStarted()' and 'fireBuildFinished()' should definately be the responsibility of Project.java, and not Main.java. However, one would probably need a new method over executeTask() so that the build started/finshed events are only fired at the appropriate times. Yada yada yada. Incidentally, I have a TODO to put together a list of proposed changes to the Main.java and Project.java classes relative to this sort of refactoring (and adding Javadoc!). I think there are several instances where the behavioral responsibilities could be better definied and allocated. Hopefully this will generate some interesting discussions. Simeon b __________________________________________________ Do You Yahoo!? Thousands of Stores. Millions of Products. All in one Place. http://shopping.yahoo.com/
