Hi, Looks cool but two things.
1) <p4counter counter="change"/> doesn't seem to work as you've not created a setCounter method but I think this is just a typo in your javadoc maybe? <p4counter name="foo" value="123"/> works just fine. 2) Could you update the Perforce tasks manual and post a diff for one of the committers to erm, commit.... Bye, Les (BTW, you don't need to re-work P4Handler to grab the counter number into a prop, use an anon inner class derived from P4HandlerAdapter, see P4Change for an example.) > -----Original Message----- > From: Kirk Wylie [mailto:[EMAIL PROTECTED] > Sent: 29 March 2001 16:25 > To: [EMAIL PROTECTED] > Subject: [Patch] New task: <p4counter> > > > The attached patch, along with the source file attached, will > implement a > new task, <p4counter>, which will get and/or set a perforce counter. > (perforce counters are extremely useful for automated build > environments). > > The second file goes in > jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/pe > rforce (I > didn't know how to do "cvs diff" such that it would include > that file in > the diff, if someone else knows that would be great). > > Please let me know if there's another command I should be > using to produce > diffs, I just did "cvs -z6 diff -u" to produce this. > > Kirk Wylie > > -- > Kirk Wylie | mailto:[EMAIL PROTECTED] | http://www.radik.com >
