[EMAIL PROTECTED] wrote:
donaldp 01/09/30 06:22:13
Modified: src/main/org/apache/tools/ant Tag: ANT_14_BRANCH Target.java
Log:
Reworked dependency parser so that it can not have empty strings as dependency and nor can it end in a , character.
Peter, you just missed the ANT_141_B1 tag :-). I'll merge it across but before I do, you may want to address some issues. Your code can cause confusing error messages if the dependency ends with two commas -
project name="test" default="blah" basedir=".">
<target name="test">
<echo message="hello"/>
</target><target name="blah" depends="test,,"/> </project>
gives
Buildfile: build.xml
BUILD FAILED
Target `,' does not exist in this project. It is used from target `blah'.
Similarly, changing it to <target name="blah" depends="test,,test"/>
gives
/home/conor/antdev/bugs/targetdepcheck/build.xml:6: Syntax Error: Depend attribute for target "blah" ends with a , character
You need to check that the dependency tokens are not delimiters and that the delimiter tokens are indeed delimiters.
Conor
