bodewig     01/10/19 00:24:29

  Modified:    src/main/org/apache/tools/ant Project.java
  Log:
  At least print a warning if users try to redefine tasks or datatypes.
  
  PR: 3205
  
  This doesn't really solve the original problem, which cannot be solved
  in Ant 1.x IMHO, that's why I didn't close the bug.
  
  Revision  Changes    Path
  1.76      +10 -0     jakarta-ant/src/main/org/apache/tools/ant/Project.java
  
  Index: Project.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
  retrieving revision 1.75
  retrieving revision 1.76
  diff -u -r1.75 -r1.76
  --- Project.java      2001/08/18 14:59:39     1.75
  +++ Project.java      2001/10/19 07:24:29     1.76
  @@ -401,6 +401,11 @@
       }
   
       public void addTaskDefinition(String taskName, Class taskClass) {
  +        if (null != taskClassDefinitions.get(taskName)) {
  +            log("Trying to override old definition of task "+taskName, 
  +                MSG_WARN);
  +        }
  +
           String msg = " +User task: " + taskName + "     " + 
taskClass.getName();
           log(msg, MSG_DEBUG);
           taskClassDefinitions.put(taskName, taskClass);
  @@ -411,6 +416,11 @@
       }
   
       public void addDataTypeDefinition(String typeName, Class typeClass) {
  +        if (null != dataClassDefinitions.get(typeName)) {
  +            log("Trying to override old definition of datatype "+typeName, 
  +                MSG_WARN);
  +        }
  +
           String msg = " +User datatype: " + typeName + "     " + 
typeClass.getName();
           log(msg, MSG_DEBUG);
           dataClassDefinitions.put(typeName, typeClass);
  
  
  

Reply via email to