> -----Original Message-----
> From: Erik Hatcher [mailto:[EMAIL PROTECTED]
> While I'm sure Stephane automated the process of this cleanup
> (he's not the
> kind of guy that would do things the hard way :), I'd like to publicly
Ah ! you never know ! :)
That was about 1100+ fixes for this one. The problem was more CVS than
anything else :-)
> applaud him for doing this level of cleanup. Its
> contributions like that
> keep Ant and Jakarta a pleasure to work with. Cleaning up imports and
> keeping the code style crisp and clean make a huge difference in its
> maintainability, readability, and plain and simple
> extensibility and its
> often the part of coding that takes a back seat to outdated notions of
> "convenience" and "deadlines".
It's not that I did much these last 2 months, so that's the least I can do
right now...Stefan and Conor are doing an tremendous job with the code.
> Thanks Stephane. And I bet he also thanks the test suites for
> making this
> global change mostly headache free (or at least I hope so,
> any bumps in this
> process to report Stephane?).
No sweat. There is no code fix involved in this besides changing the import
and modifiers, so it really does not touch the implementation itself and is
normally safe. I still have some code clean up in the pipe to do because I
would like to put ALL if/else/while/for with a block to avoid things such as
the following that can really make you crazy when debugging because you
don't see there is no block:
if (flag)
doSomething();
doConfuseYourEnemyWithIndent();
More simply, we tend to add things inside condition/loops than remove it, so
it's good practice to me to always put a block.
The fix for this will be automatic as well unfortunately the code style will
suffer a little bit, so I might need to do a second pass by hand or find an
indent tool that is good enough not to break everything. :-(
Stephane
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
