On Fri, 9 Nov 2001, Jose Alberto Fernandez wrote: > From: "Holger Engels" <[EMAIL PROTECTED]> > > > > > I just implemented ant as a matching task with support for nested > > filesets. Assuming, that the current directory contains sub1.xml and > > sub2.xml, the following three blocks have the same effect: > > > > <ant target="main"> > > <include name="sub*"/> > > </ant> > > > > > > <ant target="main"> > > <fileset dir="."> > > <include name="sub1.xml"/> > > </fileset> > > </ant> > > > > > > <ant antfile="sub1.xml" target="main"/> > > <ant antfile="sub2.xml" target="main"/> > > > > 'dir' acts as the basedir for the matching task's fileset, if > > (in|ex)cludes(file)? has been provided. 'antfile' or it's default > > "build.xml" are added to the matching tasks includes if no other includes > > / excludes have been specified and no nested filesets do exist. > > > > I have a problem with using "dir" in this way. The reason is that "dir" > means "set basedir to this value". Which I doubt is the correct interpretation > it the buildfiles are more than one level down. > > <ant dir="sub" target="xx"> > <include name="sub1/**/build.xml" /> > </ant> > > with which value for basedir will this tasks be running. I doubt "sub" > is the correct value for all of them. But that is the current meaning of > "dir". > > I think it is best not making the task extend from MatchingTask but > still support <fileset> elements or as I call it <antfileset> :-) > > <ant target="xx"> > <fileset dir="sub"> > <include name="sub1/**/build.xml" /> > </fileset> > </ant> > > here the different meanings of dir are kept appart. And in this particular > case > you will be using the "basedir" defined in the sub-buildfiles. If you use > <ant dir="xyz"> then it should mean use this value for "basedir", as it does > today. >
Ok, I agree. I'm going to remove the matching task stuff and only support nested antfilesets. This makes it better understandable. If I got you right, the 'dir' attribute of ant should override the dir of any particular fileset. Holger -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
