DO NOT REPLY [Bug 4871] New: - the cvs task does not have a mechanism to set CVS_RSH

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4871>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4871

the cvs task does not have a mechanism to set CVS_RSH

           Summary: the cvs task does not have a mechanism to set CVS_RSH
           Product: Ant
           Version: 1.4.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Core tasks
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


the cvs task is lacking the ability to set the CVS_RSH field which makes it 
inconvenient to use the cvs task to checkout files from a cvs server with ssh.

I'm including two patch files below, patched against the 1.4.1 distribution.

--- cvs.html    Wed Nov 14 09:17:20 2001
+++ cvs.html.new        Wed Nov 14 09:19:43 2001
@@ -31,6 +31,11 @@
     <td align="center" valign="top">No</td>
   </tr>
   <tr>
+    <td valign="top">cvsRsh</td>
+    <td valign="top">the CVS_RSH variable.</td>
+    <td align="center" valign="top">No, default is &quot;rsh&quot;</td>
+  </tr>
+  <tr>
     <td valign="top">dest</td>
     <td valign="top">the directory where the checked out files should be 
placed.</td>
     <td align="center" valign="top">No, default is project's basedir.</td>



--- Cvs.java    Wed Nov 14 09:01:27 2001
+++ Cvs.java.new        Wed Nov 14 09:22:01 2001
@@ -77,6 +77,12 @@
     private String cvsRoot;
 
     /**
+     * the CVS_RSH variable.
+     */
+
+    private String cvsRsh = "rsh";
+
+    /**
      * the package/module to check out.
      */
     private String pack;
@@ -172,6 +178,13 @@
             env.addVariable(var);
         }
 
+       {
+           Environment.Variable var = new Environment.Variable();
+           var.setKey("CVS_RSH");
+           var.setValue(cvsRsh);
+           env.addVariable(var);
+       }
+
         ExecuteStreamHandler streamhandler = null;
         OutputStream outputstream = null;
         OutputStream errorstream = null; 
@@ -242,6 +255,19 @@
 
         this.cvsRoot = root;
     }
+
+    public void setCvsRsh(String path) {
+        // Check if empty cvsrsh => set it to rsh 
+        if (path != null) { 
+            if (path.trim().equals("")) 
+                path = "rsh"; 
+        } else {
+           path = "rsh";
+       }
+
+        this.cvsRsh = path;
+    }
+
 
     public void setPort(int port){
         this.port = port;

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>