This looks good and I will probably commit it in a bit. Just a few requests ;)
Please don't name your patches patches.txt or patches.zip - it gets difficult to distinguish between all the different patches. It would be much easier to distinguish if you called them things like gzip-refactor.patch Also somehow the new files seem to be injected in the middle of the file. This is not a format my patch program understands. Would it be possible to just include any new files as attachments in the future - tah ;) On Thu, 15 Nov 2001 06:16, Magesh Umasankar wrote: > I received the e-mail attachment from ant-dev properly, > but for some reason the whole attachment is not > being displayed in the archive at > http://marc.theaimsgroup.com/?l=ant-dev&m=100576445217667&w=2 > > Maybe it is a bug there at MARC, but, I just want to > make sure you do receive the whole attachment - I have > zipped it up now. > > Magesh > > On Thu, 15 Nov 2001 Magesh Umasankar wrote : > > > > > Hi, > > Here are two new ant tasks - BZip2 and BUnzip2. These > > two tasks use the BZip2 compression algorithm (Visit: > > http://sourceware.cygnus.com/bzip2/ for more info.) for > > > > packing and unpacking. > > > > These tasks resemble GZip and GUnzip tasks in input, > > input validation, etc. Hence, I refactored GZip and > > GUnzip tasks as well so that the tasks GZip and BZip2 > > extend from a common base class named Pack, and > > GUnzip and BUnzip2 extend from a common base class > > named > > Unpack. This lays the foundation for creating more > > Pack > > tasks based on different algorithms like lzop, etc. in > > the future. > > > > The BZip2 and BUnzip2 tasks depend upon 4 classes: > > BZip2Constants.java > > CBZip2InputStream.java > > CBZip2OutputStream.java > > CRC.java > > > > Keiron Liddle ([EMAIL PROTECTED]) has graciously > > accepted to contribute the above code files he has > > authored, under ASF license - many thanks to him. I > > have packaged them under org.apache.tools.bzip2, > > mimicking the package naming style that has been used > > for zip and tar tools we already have. I have also > > given proper credits to him in the code. Perhaps, this > > > > needs to exist under jakarta-commons, as Stefan had > > suggested, but till then... > > > > Please consider this patch for committing. > > > > Thanks, > > Magesh > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED] > > karta.apache.org> > > For additional commands, e-mail: > > <mailto:[EMAIL PROTECTED]> -- Cheers, Pete -------------------------------------------------- "An intellectual is someone who has been educated beyond their intelligence." -------------------------------------------------- -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
