From: "Rob Oxspring" <[EMAIL PROTECTED]>

> The upshot of all this was that I've integrated the three encoding formats
> into a single task using JavaMail if available or uu encoding (via
> sun.misc.UUEncoder - presumably available to any sun based JDK?).

This looks great to me.  I will let Steve (and Erik, being a co-author) and
others
make the call on this one.

> It should be possible to drop in the new task where the old one was used
and
> not notice the difference.

Ideal.

> Magesh: your includefilenames patch caught me mid flow so I've tried to
> patch it in but would appreciate it if you would have a quick check that
> things are coming out OK.  Only the PlainMailer is affected by this
> attribute since I didn't know how best to add it into the other formats.

It works OK and you are right: this makes sense only the PlainMailer.

> Todo: Probably could find / implement uu encoding but Sun's solution was
> handy and did the trick for now.

IIRC, Orion had some home-brewed UUEncoder...  Anyway, UUEncoding
is a popular algorithm, and can be implemented easily.  But, as you say,
it is ok for now.  However, dependency on sun.* packages must be
eliminated, if at all possible.

> Hope its deemed good enough...

I do ;-)

Thanks,
Magesh



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to