This rules are really interesting but just for your information: - spaces have been trimmed in the depends list since CVS version 1.1 of Target.java so we should just be trimming when we get the name in the first place maybe warning when !targetName.equals(targetName.trim()).
- since CVS version 1.22.2.1, the name "" is considered an error in depends lists; first ignored and later throwing a BuildException outright. So it makes very little sense to support them since they cannot be used here. Since apparently people on the edge were using them we may have to put a warning, although to me they went off the cliff already. ;-) This are all released versions, so it is not a 1.5 thing. Jose Alberto ----- Original Message ----- From: "Peter Donald" <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Sunday, February 24, 2002 9:17 AM Subject: Re: <ant> > On Sun, 24 Feb 2002 20:02, Steve Loughran wrote: > > Also, targets name " " are in the silly category, but I > > dont have a check for them. Just think how many cpu cycles would be wasted > > over time if every time a target in ant was created included a look to > > verify that nobody was creating a target name containing nothing but > > spaces. (yes, I know, you scan forwards till the first non space is hit, > > but I take the view if you want to try that hard, we should let you) > > I really don't think it is that much of a performance killer. Perhaps > 1/1000th of the time spent in the XML parsing :) > > I would just warn when any character not in the set > > a-z A-Z 0-9 . - _ > > Maybe drop the '.' so names ar emore consistent with defacto xml naming > conventions. > > -- > Cheers, > > Pete > > --------------------------------------- > Be nice to your friends. If it weren't > for them, you'd be a complete stranger. > --------------------------------------- > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
