Ok, I made changes per Cyrille Morvan's suggestions. Except, I still do no think the Abstract class should do any Java invocation. There is no guarantee that the vendor-task will be written in Java. While it's not a big deal no override the Abstract deploy() method, several people have already said they would rather not see Java specific stuff in the abstract class.
Anyone care to chime in? Erik. Can you please commit these changes and ignore the previous email? Thank you. - Chris -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 27, 2002 8:32 AM To: 'Ant Developers List' Subject: RE: [PATCH] : ejbdeploy task Ok, I will all the specific stuff down to the abstact class. Let me up some changes and see what you think. > - The abstract class should provide a default deploy() implementation. Using abstract method to construct the java task. -----Original Message----- Sure, it can't, because you can't use the same url to deploy on several servers. So, I repeat, you should move server, username and password from ServerDeploy to the Abstract class. Or duplicate the username and password properties, in the two classes, and implement a getUsername() and getPassword() in the Abstract class to read local values before to read the ServerDeploy values. <serverdeploy source="file" action="deploy"> <weblogic username="cyrille" server="http://myserverONE:9898/weblogicconsole/"; /> <weblogic username="joe" server="http://myserverTWO:958/weblogicconsole/"; /> <jonas server="http://myserverThree:8080/jadmin/deploy.jws"; /> </serverdeploy> - Do you think it's a good : <serverdeploy source="file" action="deploy"> <weblogic username="cyrille" server="http://myserverOne:9898/weblogicconsole/"; /> <websphere username="joe" server="http://myserverTWO:958/weblogicconsole/"; /> <jonas server="http://myserverThree:8080/jadmin/deploy.jws"; /> <classpath> <include>/weblogic/lib/*.jar</include> <include>/websphere/lib/*.jar</include> <include>/jonas/lib/*.jar</include> </classpath> </serverdeploy> No because, we will have conflict with jndi.properties files and other stuffs. I prefer this : <serverdeploy source="file" action="deploy"> <weblogic username="cyrille" server="http://myserverOne:9898/weblogicconsole/"; > <classpath> <include>/weblogic/lib/*.jar</include> </classpath> </weblogic> <websphere username="joe" server="http://myserverTwo:958/weblogicconsole/"; > <classpath> <include>/websphere/lib/*.jar</include> </classpath> </websphere> <jonas server="http://myserverThree:8080/jadmin/deploy.jws"; jonasroot="/jonas" /> <classpath> <include>anything else</include> </classpath> </serverdeploy> - The abstract class should provide a default deploy() implementation. Using abstract method to construct the java task. - And at the end. The static values for the action, should no be in WebLogic class, but in the interface or the abstract class ,because all the implementation need it. Thanks. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
serverdeploy.tgz
Description: application/compressed
Index: jakarta-ant/docs/manual/optionaltasklist.html =================================================================== RCS file: /home/cvspublic/jakarta-ant/docs/manual/optionaltasklist.html,v retrieving revision 1.26 diff -u -r1.26 optionaltasklist.html --- jakarta-ant/docs/manual/optionaltasklist.html 22 Feb 2002 08:29:37 -0000 1.26 +++ jakarta-ant/docs/manual/optionaltasklist.html 27 Mar 2002 04:19:51 -0000 @@ -44,6 +44,7 @@ <a href="OptionalTasks/renameextensions.html"><i>RenameExtensions</i></a><br> <a href="OptionalTasks/replaceregexp.html">ReplaceRegExp</a><br> <a href="OptionalTasks/rpm.html">Rpm</a><br> +<a href="OptionalTasks/serverdeploy.html">ServerDeploy</a><br> <a href="OptionalTasks/script.html">Script</a><br> <a href="OptionalTasks/sound.html">Sound</a><br> <a href="OptionalTasks/sos.html">SourceOffSite</a><br> Index: jakarta-ant/docs/manual/OptionalTasks/ejb.html =================================================================== RCS file: /home/cvspublic/jakarta-ant/docs/manual/OptionalTasks/ejb.html,v retrieving revision 1.19 diff -u -r1.19 ejb.html --- jakarta-ant/docs/manual/OptionalTasks/ejb.html 24 Mar 2002 14:51:03 -0000 1.19 +++ jakarta-ant/docs/manual/OptionalTasks/ejb.html 27 Mar 2002 04:19:56 -0000 @@ -62,7 +62,6 @@ <tr><td><a href="BorlandGenerateClient.html">blgenclient</a></td><td colspan="2">Borland Application Server 4.5</td></tr> <tr><td><a href="#ddcreator">ddcreator</a></td><td colspan="2">Weblogic 4.5.1</td></tr> <tr><td><a href="#ejbc">ejbc</a></td><td colspan="2">Weblogic 4.5.1</td></tr> - <tr><td><a href="ejbdeploy.html">ejbdeploy</a></td><td colspan="2">EJB hot server deployment</td> <tr><td><a href="#iplanet-ejbc">iplanet-ejbc</a></td><td colspan="2">iPlanet Application Server 6.0</td></tr> <tr><td rowspan="7"><a href="#ejbjar">ejbjar</a></td><td colspan="2" align="center"><b>Nested Elements</b></td></tr> <tr><td><a href="BorlandEJBTasks.html">borland</a></td><td>Borland Application Server 4.5</td></tr> Index: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties =================================================================== RCS file: /home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties,v retrieving revision 1.115 diff -u -r1.115 defaults.properties --- jakarta-ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties 24 Mar 2002 14:51:03 -0000 1.115 +++ jakarta-ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties 27 Mar 2002 04:20:44 -0000 @@ -151,7 +151,7 @@ soslabel=org.apache.tools.ant.taskdefs.optional.sos.SOSLabel echoproperties=org.apache.tools.ant.taskdefs.optional.EchoProperties splash=org.apache.tools.ant.taskdefs.optional.splash.SplashTask -ejbdeploy=org.apache.tools.ant.taskdefs.optional.ejb.EjbDeploy +serverdeploy=org.apache.tools.ant.taskdefs.optional.j2ee.ServerDeploy # deprecated ant tasks (kept for back compatibility) starteam=org.apache.tools.ant.taskdefs.optional.scm.AntStarTeamCheckOut
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
