----- Original Message ----- From: "Stefan Bodewig" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, April 29, 2002 6:40 AM Subject: Re: [PATCH] DirectoryScanner - adds method setFollowLinks()
> On Sun, 28 Apr 2002, Patrick Heck <[EMAIL PROTECTED]> wrote: > > > This patch allows developers using DirectoryScanner to specify > > whether or not a given instance should report files for which > > File.getCanoniacalPath() and File.getAbsolutePath() are not equal > > (such as symbolic links in linux). > > It seems to work reliably on Unix systems, but I'm afraid it will > break down on certain other systems. AFAIK canonical path and > absolute path may differ in case for Windows for example. > This is something I am uninformed on, particularly with respect to WinXP and the NT series. I have only ever touched one Win2k box, and that is 'managed' by our IT department. I would be very interested to know what the scenario for non-symlink but differing Canonical and Absolute on windows is though (or any other OS). > > The patch also includes a test case for this behavior change. > > Great, thank you. > > You may want to also provide a new followsymlinks attribute to FileSet > so that arbitrary tasks could make use of the new feature without any > changes to the tasks themselves. The "delete follows symlinks" bug > could be fixed that way, for example. > If my patch can be used to fix a bug, that sounds great! I had also thought of doing this, but during the week I will be working on the symlink task since that is what is actually directly relevant to the job I am paid to do :). However I might make this extension to filesets next weekend as a separate patch. > All in all, I'm +1 for your patch, but would really want to have some > people on non-Unix systems (i.e. not me) to see whether it has some > strange side effects for them. > Thanks for the +1 and I am very +1 for it being checked out by people on other OS's (also not me :) ). Gus -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
