----- Original Message -----
From: "Craeg K Strong" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, April 30, 2002 2:42 AM
Subject: status of XMLCatalog load from file patch, questions
> I also noticed that the current XMLCatalog implementation features the
ability to find resources
> inside jar files in the classpath. Norm's resolver library does not
include this feature,
> and I think its a nice add. I am proposing to keep this code as a
secondary
> lookup after the original lookup is done using catalog.getResolvedEntity()
(using Norm Walsh's code).
Yes, I feel that JAR lookup is mandatory for resolution.... web.xml's DTD is
inside j2ee.jar, for example.
> 1) Add a new optional file attribute to <xmlcatalog>
>
> <xmlcatalog id="mycatalog" file="foo/bar/catalog">
> <dtd
> publicId = "-//ArielPartners//DTD XML Article V1.0//EN"
> location = "com/arielpartners/knowledgebase/dtd/article.dtd"/>
> </xmlcatalog>
+1
Will it look for catalog files in JAR's as well? I'd like it to.
> What's the downside? The major one I can think of is that ant needs to
now include
> all of the classes in the xml-commons resolver library. That means
either
> they need to be directly included in ant.jar _or_ we need to include a
separate
> resolver.jar with ant.
I'm ok on yet another dependency shipping with Ant, especially for this kind
of benefit, but this is ultimately for others to approve also.
> OK that's (more than) enough for one email. Please let me know what you
all think.
>
> As far as I know, there are as yet no tests for XMLCatalog. Therefore, my
patch will focus on
> the required changes to a) code b) documentation c) the ant build.xml file
Look at the XmlValidateTest - I added use of <xmlcatalog> in there, which
actually even tests the classpath resolution.
Erik
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
