> > Here are the things that stood out: the property file reading doesn't > check > > the "failonerror" flag > > Right. I will fix that.
Done. I also added some more error checking for srcfile and destfile and a new test that checks if failonerror works when reading a property file. After your review, I consider the task commitable... Ingmar
EchoProperties.java.diff
Description: Binary data
echoproperties.xml.diff
Description: Binary data
EchoPropertiesTest.java.diff
Description: Binary data
<project name="test" default="def" basedir=".">
<target name="def">
</target>
<target name="setup">
<property name="a.set" value="true" />
<property name="b.set" value="false" />
</target>
<target name="testEchoToLog" depends="setup">
<echoproperties />
</target>
<target name="testEchoToLogXml" depends="setup">
<echoproperties format="xml" />
</target>
<target name="testReadAndEchoToLog" depends="setup">
<echoproperties srcfile="echoproperties.properties" />
</target>
<target name="testReadBadFile" depends="setup">
<echoproperties srcfile="." />
</target>
<target name="testReadBadFileFail" depends="setup">
<echoproperties srcfile="." failonerror="yes" />
</target>
<target name="testReadBadFileNoFail" depends="setup">
<echoproperties srcfile="." failonerror="no" />
</target>
<target name="testEchoToBadFile" depends="setup">
<echoproperties destfile="." />
</target>
<target name="testEchoToBadFileFail" depends="setup">
<echoproperties destfile="." failonerror="yes" />
</target>
<target name="testEchoToBadFileNoFail" depends="setup">
<echoproperties destfile="." failonerror="no" />
</target>
<target name="testEchoToGoodFile" depends="setup">
<echoproperties destfile="test.properties" />
</target>
<target name="testEchoToGoodFileXml" depends="setup">
<echoproperties destfile="test.xml" format="xml" />
</target>
<target name="testEchoToGoodFileFail" depends="setup">
<echoproperties destfile="test.properties" failonerror="yes" />
</target>
<target name="testEchoToGoodFileNoFail" depends="setup">
<echoproperties destfile="test.properties" failonerror="no" />
</target>
<target name="testEchoPrefix" depends="setup">
<echoproperties destfile="test-prefix.properties" prefix="a." />
</target>
<target name="cleanup">
<delete file="test.properties" failonerror="no" />
<delete file="test-prefix.properties" failonerror="no" />
<delete file="test.xml" failonerror="no" />
</target>
</project>
echoproperties.properties
Description: Binary data
EchoPropertiesTest.java
Description: Binary data
EchoProperties.java
Description: Binary data
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
