Erik, a quick explanation...
Being a user of the Ant API from a task writer and a writer of code that calls Ant, the documentation of the API is one area that pains me. The code we sucked into maven to allow property exporting got the documentation 'fixed' as part of normal development, but it's hard for me to do that with the Ant codebase, as I look at it fairly infrequently and my cvs copy is usually out of date. Believe me, the last thing you'd want is me sending you old patches that don't apply :) -- dIon Gillard, Multitask Consulting Work: http://www.multitask.com.au Developers: http://adslgateway.multitask.com.au/developers "Erik Hatcher" <[EMAIL PROTECTED] To: "Ant Developers List" <[EMAIL PROTECTED]> tions.com> cc: Subject: Re: cvs commit: 06/19/02 01:01 PM jakarta-ant/src/main/org/apache/tools/ant/taskdefs Ear.java Jar.java Please respond to "Ant Zip.java Developers List" Could not be null if you're writing an Ant build file. Only if you are calling through the API could you pass a null. If the fileset is empty, that would be fine, as I'm sure could easily happen through a build file when no files exist in the directory specified, or none match the includes, or all are excluded. Don't give me a hard time.... I'm just a poor boy improving the documentation! :) ----- Original Message ----- From: <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, June 18, 2002 10:14 PM Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Ear.java Jar.java Zip.java > > Erik, > > are there any requirements on 'fs'? What if it's null? What if the fileset > is empty? > -- > dIon Gillard, Multitask Consulting > Work: http://www.multitask.com.au > Developers: http://adslgateway.multitask.com.au/developers > > > > "Erik Hatcher" > <[EMAIL PROTECTED] To: "Ant Developers List" <[EMAIL PROTECTED]> > tions.com> cc: > Subject: Re: cvs commit: > 06/19/02 12:03 PM jakarta-ant/src/main/org/apache/tools/ant/taskdefs Ear.java Jar.java > Please respond to "Ant Zip.java > Developers List" > > > > > > > > [EMAIL PROTECTED] wrote: > > > + /** > > > + * Adds zipfileset. > > > + * > > > + * @param fs > > > + */ > > > public void addArchives(ZipFileSet fs) { > > > // We just set the prefix for this fileset, and pass it up. > > > // Do we need to do this? LH > > > > Don't you want some description of fs? > > Yes. I'm trying to catch these. IDEA is automatically adding the @params > for new Javadoc blocks. Its hard for me to bring myself to duplicate what > was just said above though. I'll fix this one and others that I create. > > Will <javadoc> complain if they are missing? Or I'm assuming Checkstyle > would? > > Thanks, > Erik > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
