ehatcher 2002/06/22 19:06:06
Modified: src/main/org/apache/tools/ant/taskdefs Tag: ANT_15_BRANCH
Chmod.java ExecTask.java ExecuteOn.java
Log:
note some exceptional situations: setters that are deprecated, and the use of
a protected variable that is brittle.
Revision Changes Path
No revision
No revision
1.27.2.3 +3 -6
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Chmod.java
Index: Chmod.java
===================================================================
RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Chmod.java,v
retrieving revision 1.27.2.2
retrieving revision 1.27.2.3
diff -u -r1.27.2.2 -r1.27.2.3
--- Chmod.java 19 Jun 2002 01:19:12 -0000 1.27.2.2
+++ Chmod.java 23 Jun 2002 02:06:06 -0000 1.27.2.3
@@ -233,8 +233,7 @@
}
/**
- * Not supported.
- * @param e
+ * @ant.attribute ignore="true"
*/
public void setExecutable(String e) {
throw new BuildException(taskType
@@ -242,8 +241,7 @@
}
/**
- * Not supported.
- * @param cmdl
+ * @ant.attribute ignore="true"
*/
public void setCommand(Commandline cmdl) {
throw new BuildException(taskType
@@ -251,8 +249,7 @@
}
/**
- * Not supported.
- * @param skip
+ * @ant.attribute ignore="true"
*/
public void setSkipEmptyFilesets(boolean skip) {
throw new BuildException(taskType
1.36.2.4 +1 -2
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/ExecTask.java
Index: ExecTask.java
===================================================================
RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/ExecTask.java,v
retrieving revision 1.36.2.3
retrieving revision 1.36.2.4
diff -u -r1.36.2.3 -r1.36.2.4
--- ExecTask.java 19 Jun 2002 02:17:27 -0000 1.36.2.3
+++ ExecTask.java 23 Jun 2002 02:06:06 -0000 1.36.2.4
@@ -147,8 +147,7 @@
}
/**
- * Deprecated, use executable instead.
- * The full commandline to execute, executable + arguments.
+ * @ant.attribute ignore="true"
*/
public void setCommand(Commandline cmdl) {
log("The command attribute is deprecated. " +
1.30.2.3 +4 -0
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java
Index: ExecuteOn.java
===================================================================
RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java,v
retrieving revision 1.30.2.2
retrieving revision 1.30.2.3
diff -u -r1.30.2.2 -r1.30.2.3
--- ExecuteOn.java 19 Jun 2002 00:03:16 -0000 1.30.2.2
+++ ExecuteOn.java 23 Jun 2002 02:06:06 -0000 1.30.2.3
@@ -184,6 +184,10 @@
return mapperElement;
}
+ /**
+ * @todo using taskName here is brittle, as a user could override it.
+ * this should probably be modified to use the classname instead.
+ */
protected void checkConfiguration() {
if ("execon".equals(taskName)) {
log("!! execon is deprecated. Use apply instead. !!");
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
