Yes, I saw that wonderful modification to support <import>, which is exactly what we needed, but since it's not going to be in Ant 1.5 we're (so far) going to just use included XML snippets. I'm looking forward to seeing and trying Antipede! :)

But, for the time being, and for Ant 1.5, I'd just like Ant to
correctly report which file needs fixing when something went wrong.
It's a very small change (a single line of code), with a big benefit.

--
Jason Brittain
<jasonb (~at~) collab (~dot~) net>
CollabNet http://www.collab.net

Dominique Devienne wrote:
You might want to look at
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10276 which adds the
<import> top-level element with special handling in ProjectHelperImpl.java.
Your patch may (or not) need to address what the patch there does for proper
error reporting too. Thanks, --DD

-----Original Message-----
From: Jason Brittain [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 02, 2002 8:14 PM
To: [EMAIL PROTECTED]
Subject: [PATCH] Buid file parse error msgs wrong when including XML
snippets



Hi there.

Currently, whenever you include an XML snippet in a project file like
the FAQ shows here:

http://jakarta.apache.org/ant/faq.html#xml-entity-include

It works fine, but if there's a parser error in the file I'm including,
Ant incorrectly tells me that the error is in the file I included it in
(instead of in the included file).  I believe this is a bug.

The attached patch of ProjectHelperImpl.java (CVS head's version) seems
to fix this problem for parse errors.  I've also attached a patch for
Ant 1.4.

Can/should this be fixed by Ant 1.5 (final)?

There are also other spots where this same bug probably occurs after
Project parse time, which I'm going to investigate next..

Cheers.




-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>



Reply via email to