Hi Magesh, I finally had a chance to look at it, and it works for me. All except for a problem that I caused, where the zip task doesn't work correctly if you're using filesetmanifest and update is false. Attached is a patch that makes sure an empty jar is created on the first pass when using filesetmanifest. Thanks! -Brian
> -----Original Message----- > From: Magesh Umasankar [mailto:[EMAIL PROTECTED] > Sent: Thursday, November 21, 2002 4:47 PM > To: Ant Developers List > Subject: Re: [PATCH] reenable jar's filesetmanifest > > > Patch applied to cvs. Thanks! > > Please test drive it and see ensure I haven't messed > things up. > > Cheers, > Magesh > > ----- Original Message ----- > From: "Brian Deitte" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, September 26, 2002 1:51 PM > Subject: [PATCH] reenable jar's filesetmanifest > > > > Hi, I finally got around to reenabling the filesetmanifest > attribute on > the jar task. This was disabled since in this case the > manifest was not > written to the zip file first, and this causes problems with > JarInputStream. > > > > I started to fix this bug by refactoring the Zip class so > that the fileset > parsing pieces were in a different class... but this was > taking to long. I > have the unfinished code around (50-75% done) if anybody > wants to try it > themselves. I ended up adding code to the Zip class that > allows two passes > on the filesets, with the first pass not writing anything out to the > outputstream. This allows all the manifest information to be > gathered up > and written first on the second pass. I ran the appropriate > tests and tried > some cases out myself. Diffs attached. -Brian > > > > > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> >
Zip.java.diff
Description: Binary data
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
