Some suggestions/questions concerning the solution : 1) ZipScanner class
it is currently implemented in such a way that the getIncludedFiles() function answers with an array containing as only element the name of the zip file itself. I believe we should change the implementation of the class so that ZipScanner.getIncludedFiles() gives the list of entries in the archive which match the include and exclude patterns. Does anyone see a danger of breaking something here ? 2) DirectoryScanner and ZipScanner classes Stefan Bodewig wrote : >Where I was thinking about changes is the SourceFileScanner class, > instead of only working on files, it should work on "resources" that > had a name and a last modification time. What we'd then need was to > pass in "factories" to generate the source and target resources. +1 maybe we could create such a Resource class under org.apache.tools.ant.types it needs only two instance variables : String FileName and long ModificationTime or something like that Then the DirectoryScanner could store the results of scanning internally as vectors of Resource Classes interested in knowing the modification date/time of a file should ask the scanner, not the file directly any more. one would add two new functions in DirectoryScanner long getModificationTime(String path) and Resource [ ] list(String path) this list function would be redefined in ZipScanner to list the zip entries and would be called from the scandir method of the DirectoryScanner class to replace dir.list() (Java.IO.File) the rest of the logic of scandir should work; instead of maintaining vectors of filenames, one would maintain vectors of the new Resource type so that the scanner "knows" what are the modification times of each files. Afterwards, the game is to make sure that packaging tasks always find out about the date/time of files from the scanners, not directly from the file system (FileUtils) because the scanned files can be on the file system or in a zip file. How does that sound ? Antoine ----- Original Message ----- From: "Stefan Bodewig" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, January 09, 2003 9:38 AM Subject: Re: The zip update problem > On Thu, 09 Jan 2003, Conor MacNeill <[EMAIL PROTECTED]> > wrote: > > > MHO would be to get this done in whatever time it takes, release > > 1.5.2 > > Works for me as well. > > > and then call 1.5 done. > > unless an important bug gets fixed and the 1.6 release is still too > far away. > > In some way I regret we didn't release a 1.4.2 that would have been > 1.4.1 plus the WinXP/JDK 1.4 fix a year ago. > > > I'd be happier to do it right, first up and save the hack > > work. > > fair enough. > > Stefan > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
