Do the test cases run successfully?

Here's what I'd recommend if you want to tackle it:

1) Add that particular exceptional situation to the test case
2) Make sure the problem occurs before making a change to the task
3) Make your fix
4) Ensure the test case now passes
5) Commit the fix :)

I won't touch this for a few weeks, so have at it if you'd like.

    Erik

----- Original Message -----
From: "Diane Holt" <[EMAIL PROTECTED]>
To: "Ant Users List" <[EMAIL PROTECTED]>
Sent: Friday, May 03, 2002 7:53 PM
Subject: Re: 1.5Beta1 propertyfile task: Generating build number throws
NullPointerException (was: propertyfile task returning wrong date)


> --- Erik Hatcher <[EMAIL PROTECTED]> wrote:
> > If no one gets to this before I do, I'll have a look at it in a few
> > weeks or so. Could you please file this as an official Bugzilla report
> > against Ant 1.5Beta1 so that its not forgotten?
>
> I enclosed the try/catch block at line 440 in an 'if (value != null)',
> which (upon some very cursory testing -- ie., ran it with the props file
> not yet existing, with it existing but no value for "buildnum", and with
> it existing and with a value for "buildnum") seems to fix the problem --
> but since PropertyFile is now your baby, I'll leave it to you to decide if
> that's the right fix or not.
>
> Diane
>
> =====
> ([EMAIL PROTECTED])
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Health - your guide to health and wellness
> http://health.yahoo.com
>
> --
> To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
>
>


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to