All TestDFAConversion tests pass on my machine.
Jim: I see:
@Ignore
// TODO: Ter to review why this test fails...
//
public void testAStar_immediateTailRecursion() throws Exception {
but it works for me on 1.6. Can u recheck?
Sam: thanks. it works now. Changed Java.stg:
ruleLabelDefs() ::= <<
<[ruleDescriptor.tokenLabels,ruleDescriptor.tokenListLabels,
ruleDescriptor.wildcardTreeLabels,ruleDescriptor.wildcardTreeListLabels]
:{<labelType> <it.label.text>=null;}; separator="\n"
>
<
[ruleDescriptor
.tokenListLabels
,ruleDescriptor.ruleListLabels,ruleDescriptor.wildcardTreeListLabels]
:{List list_<it.label.text>=null;}; separator="\n"
>
<ruleDescriptor.ruleLabels:ruleLabelDef(label=it); separator="\n">
<ruleDescriptor.ruleListLabels:{ll|<ll:ruleLabelDef(label=it)>
<ll.label.text> = null;}; separator="\n">
>>
edit //depot/code/antlr/main/src/org/antlr/codegen/templates/Java/
Java.stg#142
edit //depot/code/antlr/main/test/org/antlr/test/
TestTreeGrammarRewriteAST.java#5
Change 5389 submitted.
Ter
On Nov 6, 2008, at 11:03 AM, Sam Harwell wrote:
> I fixed one.
>
> Test:
> TestRewriteOfRuleRefRootListLabeled
>
> Problem:
> Incorrect return type for the list label.
>
> Solution:
> In Java.stg, template ruleLabelDefs(), instead of hard-coding
> RuleReturnScope as the label type for ruleListLabels, call
> ruleLabelDef template like it does for ruleLabels.
>
> Sam
>
> From: [EMAIL PROTECTED] [mailto:antlr-dev-
> [EMAIL PROTECTED] On Behalf Of Sam Harwell
> Sent: Tuesday, November 04, 2008 12:09 PM
> To: ANTLR-dev Dev
> Subject: [antlr-dev] Unit test differences between Java and C# port
>
> The following tests that fail in the Java code (based on their
> comments / CL5370) all pass in my C# port. Maybe we can figure out
> what the difference is? Do you have any information on the current
> results of these tests?
>
> testAStar_immediateTailRecursion
> testWildcardInTreeGrammar
> testOrPredicates
> testGatedPred
> testGatedPredInCyclicDFA
> testTemplateConstructor
> testTemplateConstructorNoArgs
> testIndirectTemplateConstructor
>
> Sam
> _______________________________________________
> antlr-dev mailing list
> [email protected]
> http://www.antlr.org:8080/mailman/listinfo/antlr-dev
_______________________________________________
antlr-dev mailing list
[email protected]
http://www.antlr.org:8080/mailman/listinfo/antlr-dev
