Hi Prof. Parr:
I'm working on merging the recent StringTemplate changes and I have a few questions and some comments. First the comments: * (Bug) The new tests which mention "force \n as newline" should include the literal "\n" in the expected text. On the C# port, newline is set to "Environment.NewLine" which on Windows is "\r\n". * (Maybe Bug) You should check for (arg.defaultValueST.Chunks != null) in StringTemplate.setDefaultArgumentValues? * (Suggestion) In ASTExpr.writeIterableValue, move the block "if value to emit is a template" above the block "if not possible to be missing". Questions: * Lots of ST unit tests broke when I merged this. Can you check that they all still pass on the Java version? Thanks, Sam
_______________________________________________ antlr-dev mailing list [email protected] http://www.antlr.org/mailman/listinfo/antlr-dev
