Hello Benjamin, On Thu, Sep 9, 2010 at 2:00 PM, Benjamin Eberlei <[email protected]> wrote: > It seems the branch added two new files on the main-level to genreate the > antlr-php-target.jar > and only moved some folders around to the runtime/Php/src/Antlr/Runtime > directory. > This is about the same that I did, i moved the files to: > > runtime/Php/Antlr/Runtime/* > > i could just move them into a src/ also for consistency and our branches > are the same again from the file layout.
Please, do so in git. This way it resembles the layout of the original Java runtime. > Additionally i was thinking > about moving the tests also, but aside from the directory changes > and two new commandline tools I see no differences to the git repository > i branched off (i did check that before also). Yes, yy branch was based on last git code. > I think I did already do all the changes that you did in your yy branch, > except for the new testing layout and the two new tools in the main > directory. > I would suggest i mirror all your additional change sinto my Git > repository, > so they don't get lost. We could then merge the changes back into the > trunk and open > up new branches from there. > > Personally I favor Git over SVN though, especially for such a > decentralized project. I have no problems with git. Let's keep things there for now. >> I am currently occupied with porting StringTemplate to PHP. >> > > That is awesome, are you willing to share some code already? :-) > I am planning to make a push this weekend. I will keep you posted. >>> 3. How stable are the runtimes? I see very little commits to them, so >>> probably very stable. But how will that change with Antlr v4 in >>> development? >> >> a lot. We will have to rewrite a lot of things. But v3 is stable and >> popular enough, so it is worth the effort. >> Libraries like StringTemplate can be exploited by v4 but written for v3. >> Such "legacy" is a part of ANTLR design. > > I am beginning to port more and more of the Java testsuite to my PHP > branch, even to a point where today I have lots of the Tree support > already > working against the "TestTree.java", "TestTreeNodeStream.java" and > "TestTreeWizard.java" > testsuites, so that I can commit that in the next days. great. At the end, the ultimate test is to make a checklist with ANTLR features (basically it is http://www.antlr.org/wiki/display/ANTLR3/ANTLR+3+Wiki+Home) and to check it all through. > Yes could you please forward that correspondence? done. > I am working on the > AST/Tree > support, so we can probably merge efforts with your StringTemplate > implementation. StringTemplate takes active use of ANTLR grammar language as it has a lot of *.g and is itself a DSL. So this is always a good test for runtime. According to Terrence, currently there is no better practice for ANTLR runtime testing, then using it in action for the development of the realworld grammars. > Again, I think the changes in your yy branch are not that major compared > to the branch > I started from. I will just port the additional tools and move the > directory > structure according to yours and this should be it. Please, let me know with a short pm that git is in sync with yy. After that I will contribute to your effort in git. As soon as we have our "checklist" I think we should migrate everything to ANTLR Perforce directory, as Jim has proposed. -- With best regards, Y.Y. _______________________________________________ antlr-dev mailing list [email protected] http://www.antlr.org/mailman/listinfo/antlr-dev
