Hi Lewis, it is not essential but IMHO should be applied as much as it is possible, indeed I had to escape the RAT check for special files such as .csv/.json that don't support comments at all. Anyway, for the case I submitted, I suspect there is a bug - a plain HTML file should support comments, ASL header or not, it should not drive the testcase to fail :P
Does it sound reasonable? TIA and all the best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, May 8, 2012 at 7:59 PM, Lewis John Mcgibbney <[email protected]> wrote: > Is it essential that ASL headers go on resources for testing purposes? > > If this is breaking the test or failing something then maybe best to > ignore the header in the file (if this is possible) as it is not > directly Any23 code. > > wdyt? > > Thanks > > On Tue, May 8, 2012 at 6:44 PM, Simone Tripodi <[email protected]> > wrote: >> Hi Mike, >> >> no issues with online resources, I got the error with the >> microdata-basic.html[1] resource in the core module. >> >> Many thanks in advance, all the best! >> -Simo >> >> [1] >> https://svn.apache.org/repos/asf/incubator/any23/trunk/core/src/test/resources/microdata/microdata-basic.html >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> >> On Tue, May 8, 2012 at 7:23 PM, Michele Mostarda >> <[email protected]> wrote: >>> On 8 May 2012 15:01, Simone Tripodi <[email protected]> wrote: >>> >>>> Hi all guys, >>>> I am trying to work toward the release, and filling the ASL header >>>> where missing. >>>> >>>> So, as from subject, I added the ASL2.0 license in the file header int >>>> the microdata-basic.html[1] file, unfortunately that causes >>>> org.apache.any23.Any23Test#testMicrodataSupport() fail. >>>> >>> >>> Hi Simo, >>> >>> some of the HTML pages used to test Any23 were taken from real sites, >>> I don't know if it is possible to add on them a header with copyright. >>> >>> >>>> Does anyway has idea of why that happens? Is it a bug? >>>> TIA, all the best, >>>> -Simo >>>> >>> >>> Which is the modified input file and the raised error? >>> >>> The best. >>> Mic >>> >>> >>>> [1] >>>> https://svn.apache.org/repos/asf/incubator/any23/trunk/core/src/test/resources/microdata/microdata-basic.html >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://simonetripodi.livejournal.com/ >>>> http://twitter.com/simonetripodi >>>> http://www.99soft.org/ >>>> >>> >>> >>> >>> -- >>> Michele Mostarda >>> Senior Software Engineer >>> skype: michele.mostarda >>> twitter: micmos >>> mail: [email protected] >>> site : http://www.michelemostarda.com > > > > -- > Lewis
